Path matching based on regex#387
Closed
jandouwebeekman wants to merge 7 commits intoahx:mainfrom
Closed
Conversation
ahx
reviewed
Aug 14, 2025
| path_item = if PathTemplate.template?(path) | ||
| @dynamic[path] ||= { template: PathTemplate.new(path) } | ||
| @dynamic[path] ||= { | ||
| template: PathTemplate.new(path, path_parameters, use_patterns_for_path_matching) |
Owner
There was a problem hiding this comment.
What do you think of not calling PathTemplate.new if use_patterns_for_path_matching is true, but a new class MyPatternMatchingTemplate.new?
Contributor
Author
There was a problem hiding this comment.
I am totally fine with that but I guess we should first finish the discussion in the issue as these changes are not necessary if you do not agree with the underlying idea of the problem which means the solution will probably stay on a fork forever
Contributor
Author
|
in #386 (comment) it was determined that this would not be chosen as a solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to match paths based on the regex provided in the
patternof a path parameter.As described in #386 this might be needed in some weird APIs